Re: [PATCH 1/6] arm64: dts: renesas: r9a09g077: Add I2C controller nodes

[Geert Uytterhoeven]

Hi Prabhakar,

On Wed, 25 Jun 2025 at 17:30, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> The Renesas RZ/T2H ("R9A09G077") SoC includes three I2C (RIIC) channels.
> Adds the device tree nodes for all three I2C controllers to RZ/T2H
> SoC DTSI.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r9a09g077.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g077.dtsi
> @@ -90,6 +90,51 @@ sci0: serial@80005000 {
>                         status = "disabled";
>                 };
>
> +               i2c0: i2c@80088000 {
> +                       compatible = "renesas,riic-r9a09g077";
> +                       reg = <0 0x80088000 0 0x400>;
> +                       interrupts = <GIC_SPI 614 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 615 IRQ_TYPE_EDGE_RISING>,
> +                                    <GIC_SPI 616 IRQ_TYPE_EDGE_RISING>,
> +                                    <GIC_SPI 617 IRQ_TYPE_LEVEL_HIGH>;
> +                       interrupt-names = "eei", "rxi", "txi", "tei";
> +                       clocks = <&cpg CPG_MOD 100>;
> +                       power-domains = <&cpg>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +               };
> +
> +               i2c1: i2c@80088004 {

80088400

Aha, the related warning was demoted to W=1:

    Warning (simple_bus_reg): /soc/i2c@80088004: simple-bus unit
address format error, expected "80088400"

> +                       compatible = "renesas,riic-r9a09g077";
> +                       reg = <0 0x80088400 0 0x400>;
> +                       interrupts = <GIC_SPI 618 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 619 IRQ_TYPE_EDGE_RISING>,
> +                                    <GIC_SPI 620 IRQ_TYPE_EDGE_RISING>,
> +                                    <GIC_SPI 621 IRQ_TYPE_LEVEL_HIGH>;
> +                       interrupt-names = "eei", "rxi", "txi", "tei";
> +                       clocks = <&cpg CPG_MOD 101>;
> +                       power-domains = <&cpg>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +               };
> +
> +               i2c2: i2c@81008000 {
> +                       compatible = "renesas,riic-r9a09g077";
> +                       reg = <0 0x81008000 0 0x400>;
> +                       interrupts = <GIC_SPI 622 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 623 IRQ_TYPE_EDGE_RISING>,
> +                                    <GIC_SPI 624 IRQ_TYPE_EDGE_RISING>,
> +                                    <GIC_SPI 625 IRQ_TYPE_LEVEL_HIGH>;
> +                       interrupt-names = "eei", "rxi", "txi", "tei";
> +                       clocks = <&cpg CPG_MOD 501>;

601

> +                       power-domains = <&cpg>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +               };
> +
>                 cpg: clock-controller@80280000 {
>                         compatible = "renesas,r9a09g077-cpg-mssr";
>                         reg = <0 0x80280000 0 0x1000>,

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds