Re: [PATCH v2] dt-bindings: iio: pressure: add invensense,icp10100
From: Krzysztof Kozlowski
Date: Thu Jul 03 2025 - 03:38:40 EST
On Tue, Jul 01, 2025 at 07:05:43PM -0300, Rodrigo Gobbi wrote:
> +$id: http://devicetree.org/schemas/iio/pressure/invensense,icp10100.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: InvenSense ICP-101xx Barometric Pressure Sensors
> +
> +maintainers:
> + - Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx>
> +
> +description: |
> + Support for ICP-101xx family: ICP-10100, ICP-10101, ICP-10110, ICP-10111.
The problem with title and description here is that they do not match
compatible. oneOf:
1. Your statement is correct, but then compatibles are incomplete and
will encourage people to use incomplete compatibles for e.g. ICP-10111.
2. Compatible is correct but your statement is not correct, so then fix
the statement - drop other devices.
Assuming 1 is closer to truth, then I suggest to express it with
documenting these compatibles and using invensense,icp10100 as fallback.
Best regards,
Krzysztof