Re: [PATCH v2 6/8] dt-bindings: auxdisplay: add Titan Micro Electronics TM16XX

From: Krzysztof Kozlowski
Date: Wed Jul 02 2025 - 11:08:06 EST


On 02/07/2025 17:02, Krzysztof Kozlowski wrote:
>>
>> if:
>> properties:
>> compatible:
>> contains:
>> enum:
>> - titanmec,tm1618
>> - titanmec,tm1620
>> - titanmec,tm1628
>> - fdhisi,fd620
>> - fdhisi,fd628
>> - winrise,hbs658
>> then:
>> allOf:
>> - $ref: /schemas/spi/spi-peripheral-props.yaml#
>
> Why is this conditional? Are these devices with entirely different
> programming model? Then they usually should not be in the same binding,
> although depends on differences.

Although I looked again at driver and I think I understand - some of
these do not have SPI interface. Then fine, just put it in allOf:

allOf:
- if:
...
then:
$ref: ...

Some other example for that:
https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml#L152

Best regards,
Krzysztof