Re: [PATCH v2 6/8] arm64: dts: bst: add support for Black Sesame Technologies C1200 CDCU1.0 board
From: Albert Yang
Date: Wed Jul 02 2025 - 09:08:18 EST
Hi Krzysztof,
Thank you for your detailed review and feedback. I have addressed all the issues you mentioned:
> This is messed. SoB does not go to changelog. Apply your patch and look
> at result - do you see SoB? No, because changelog is stripped.
> submitting patches explains how this is supposed to look like.
Fixed. Moved Signed-off-by lines to the correct position in commit message,
outside of the changelog section.
> Nothing improved. I asked to follow DTS coding style in ordering.
Fixed. Reordered all nodes according to DTS coding style:
- Root level nodes: alphabetically ordered (clk_mmc → cpus → psci → soc → timer)
- SoC nodes: ordered by address (uart0@20008000 → mmc0@22200000 → gic@32800000)
- Applied consistent ordering throughout the dtsi file
> l2-cache. Otherwise it is incomplete, so add the second one.
Fixed. Renamed l2-cache-1 to l2-cache as per standard naming convention.
> Why do you have multiple memory nodes, not one?
Fixed. Consolidated multiple memory nodes into a single memory node with
multiple reg entries as required by Device Tree specification:
Before (incorrect):
memory@800151000 { reg = <0x8 0x00151000 0x0 0x1000>; };
memory@800254000 { reg = <0x8 0x00254000 0x0 0x1000>; };
...
After (correct):
memory@800151000 {
reg = <0x8 0x00151000 0x0 0x1000>,
<0x8 0x00254000 0x0 0x1000>,
<0x8 0x10000000 0x0 0x30000000>,
<0x8 0xc0000000 0x1 0x0>,
<0xc 0x00000000 0x0 0x40000000>;
};
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1`
Fixed. Ran `make dtbs_check W=1` and verified no schema violations.
DTB builds successfully without warnings.
> This is not a DTS patch. (regarding defconfig)
Fixed. Moved all defconfig changes to a separate dedicated commit as suggested.
The DTS commit now only contains device tree related changes.
Additionally, I have addressed all feedback from the v1 review:
- Fixed reserved-memory node naming (mmc0-reserved@5160000)
- Corrected all property ordering according to DTS coding style
- Ensured all nodes follow standard naming conventions
All changes have been tested with:
- make ARCH=arm64 bst/bstc1200-cdcu1.0-adas_4c2g.dtb W=1 (successful)
- DTB validation passes without errors
I will send v3 with all these fixes applied.
Best regards,
Albert Yang