Re: [PATCH v6 2/4] thermal/drivers/exynos: Use devm_clk_get_enabled() helpers

From: Mateusz Majewski
Date: Wed Jul 02 2025 - 08:00:49 EST


Hello :)

These:

> + data->clk = devm_clk_get_enabled(dev, "tmu_apbif");

> + data->clk_sec = devm_clk_get_enabled(dev, "tmu_triminfo_apbif");

should probably call devm_clk_get_prepared instead, as they are only
prepared inside current code:

> - ret = clk_prepare(data->clk);

> - ret = clk_prepare(data->clk_sec);

as elsewhere they are only enabled on use and then disabled. Only
data->sclk is enabled immediately:

> - ret = clk_prepare_enable(data->sclk);

Thank you,
Mateusz Majewski