Re: [PATCH 1/7] dt-bindings: sram: qcom,imem: Document Qualcomm IPQ SoC's IMEM compatibles
From: Krzysztof Kozlowski
Date: Wed Jul 02 2025 - 06:20:34 EST
On 02/07/2025 12:17, Kathiravan Thirumoorthy wrote:
> IMEM is present in the Qualcomm's IPQ SoCs as well. Document the same.
>
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@xxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/sram/qcom,imem.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
Where is the changelog? This is not a v1.
> diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> index 72d35e30c439ccf4901d937f838fe7c7a81f33b1..48e2f332e0e9fc9fa4147fa12d9c6c70a77fafda 100644
> --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
> @@ -18,6 +18,12 @@ properties:
> items:
> - enum:
> - qcom,apq8064-imem
> + - qcom,ipq8074-imem
> + - qcom,ipq6018-imem
> + - qcom,ipq5018-imem
> + - qcom,ipq9574-imem
> + - qcom,ipq5332-imem
> + - qcom,ipq5424-imem
Random order, no, follow existing style. This applies for every qcom
binding and you received such feedbacks in the past.
Best regards,
Krzysztof