re: drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API

From: Colin King (gmail)
Date: Wed Jul 02 2025 - 05:45:42 EST


Hi,

I believe there is a regression in linux-next caused by the following commit:

commit a59a271769149f0b8258507276f3d2a24370cbdb
Author: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
Date: Wed May 28 11:29:36 2025 +0200

drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API


the issue is as follows:

static int tc_probe_bridge_endpoint(struct tc_data *tc, enum tc_mode mode)
{
struct device *dev = tc->dev;
struct of_endpoint endpoint;
struct device_node *node = NULL;

for_each_endpoint_of_node(dev->of_node, node) {
if (endpoint.port == 2) {
...
...

The check for endpoint.port == 2 is checking an uninitialized field in the uninitialized structure endpoint. The code before this commit called of_graph_parse_endpoint(node, &endpoint) to fetch endpoint and now this seems to be missing.

Colin


Attachment: OpenPGP_0x68C287DFC6A80226.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature