Re: [PATCH v3 0/3] Decouple max_pclk check from constant display feats

From: Jayesh Choudhary
Date: Wed Jul 02 2025 - 03:02:22 EST


Hello Devarsh,

On 01/07/25 19:00, Devarsh Thakkar wrote:
On 01/07/25 15:25, Jayesh Choudhary wrote:
In an effort to make the existing compatibles more usable, we are
removing the max_pclk_khz form dispc_features structure and doing the
correspondig checks using "curr_max_pclk[]".

Changes are fully backwards compatible.

After integration of OLDI support[0], we need additional patches in
oldi to identify the VP that has OLDI. We have to do this since
OLDI driver owns the VP clock (its serial clock) and we cannot perform
clock operations on those VP clock from tidss driver. This issue was
also reported upstream when DSI fixes[1] had some clock related calls
in tidss driver. When "clk_round_rate()" is called, ideally it should
have gone to "sci_clk_determine_rate()" to query DM but it doesn't since
clock is owned by OLDI not tidss.


As series is fixing above issue (abnormal behaviour while calling clk_round_rate from tidss for VP clock being used by OLDI), can we add "Fixes tag" for the patches?


This seems like a preemptive fix. So I was not sure what to add.

If it should be added then which commit?
7246e0929945 ("drm/tidss: Add OLDI bridge support") ?

Warm Regards,
Jayesh


Regards
Devarsh