Re: [PATCH v7 02/14] dt-bindings: net: mediatek,net: update for mt7988

[Krzysztof Kozlowski]

On 01/07/2025 12:33, Frank Wunderlich wrote:
> Am 1. Juli 2025 08:41:42 MESZ schrieb Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
>> On Sat, Jun 28, 2025 at 06:54:37PM +0200, Frank Wunderlich wrote:
>>> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>>>
>>> Update binding for mt7988 which has 3 gmac and a sram for dma
>>> operations.
>>
>> I asked why you are updating. You claim you update because it has 3
>> GMAC... but that's irrelevant, because it is easy to answer with: it did
>> not have 3 GMAC before?
>>
>> So same question: Provide real reason why you are making updates. That's
>> why you have commit msg.
> 
> MT7988 had always 3 gmac,but no dts with ethernet
> node till now.
> As i try to upstream the dts,i fell over this.

What does it mean? Are you adding new device or not? Nothing explains
that something was missing.

> 
> Imho changing the regex for the mac subnodes was
> simply forgotten to be updated on initial mt7988
> support patch.

Fix
your
wrapping because
it is
difficult
to follow
such
style.

> 
> I try to rephrase it like this:
> 
> Binding was not aware for 3 MAC subnodes because
> previous mediatek SoC had only 2. Change this to allow
> 3 GMAC in mt7988 devicetree.

So a fix for existing? Than add Fixes tag, describe the issue and fix
ONLY that issue.

Best regards,
Krzysztof