Re: [PATCH v3 3/6] x86/kexec: Disable kexec/kdump on platforms with TDX partial write erratum

From: Huang, Kai
Date: Tue Jul 01 2025 - 23:12:51 EST



> > + /*
> > + * Some early TDX-capable platforms have an erratum. A kernel
> > + * partial write (a write transaction of less than cacheline
> > + * lands at memory controller) to TDX private memory poisons that
> > + * memory, and a subsequent read triggers a machine check.
> > + *
> Nit: About the description of the erratum, maybe it's better to refer to the
> comments of check_tdx_erratum() to avoid duplication. Also it gives a link to
> how/when the bug is set.

I am not sure pointing to the comment at another place is desired,
especially at another file. It could be done in some cases but IMHO in
general it's better to have a "standalone" comment so we don't need to jump
back and forth, or need to care about the case that the other comment could
be updated etc.

>
> Otherwise,
> Reviewed-by: Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx>

Thanks.