Re: [PATCH v4 net-next 1/3] net: hibmcge: support scenario without PHY

From: Andrew Lunn
Date: Tue Jul 01 2025 - 18:10:51 EST


> + phydev = fixed_phy_register(&hbg_fixed_phy_status, NULL);
> + if (IS_ERR(phydev)) {
> + dev_err_probe(dev, IS_ERR(phydev),

IS_ERR() returns a bool, where as dev_err_probe() expects an int.

> + "failed to register fixed PHY device\n");
> + return IS_ERR(phydev);

This also looks wrong.

Andrew

---
pw-bot: cr