Re: [PATCH v10 17/19] rv: Add rtapp_sleep monitor

From: Nam Cao
Date: Tue Jul 01 2025 - 17:04:26 EST


On Tue, Jul 01, 2025 at 11:17:04AM -0400, Steven Rostedt wrote:
> On Tue, 1 Jul 2025 17:11:14 +0200
> Nam Cao <namcao@xxxxxxxxxxxxx> wrote:
>
> > > There's nothing in the code that even states that this was generated
> > > (if they were).
> >
> > Yeah this entire file is generated from the LTL specification. I will add a
> > comment.
>
> Yeah, generated code needs a big comment at the top of the file on what
> generated it.

Sure.

> Bonus points if it shows how it was generated so that people will know
> how to regenerate it.

If it's okay, not in this series. It requires changes to the RV core
script, and I prefer not touching things which are not LTL-specific for
now, unless necessary. The DA monitors and the containers do not have it as
well.

Let me stash it into my TODO list of RV cleanups. I will add this for LTL,
deterministic automaton and container in one go.

Best regards,
Nam