Re: [PATCH 0/3] Add x1e Dell Inpsiron 14p

[Aleksandrs Vinarskis]

On 4/24/25 01:53, Bryan O'Donoghue wrote:
> Add in a dtsi for the Dell Inspiron 14p.
>
> I'm currently using this as a daily driver including sending this series
> from. Its reasonably stable on 6.15-rcX.
>
> The first two patches can be applied without dependency, the final patch
> relies on patches staged for -next in the media tree to be applied,
> presently.
>
> https://gitlab.freedesktop.org/linux-media/media-committers/-/commit/2ab7f87a7f4bf392e3836a2600f115a1baa1415c
> https://lore.kernel.org/linux-media/20250407-b4-media-comitters-next-25-03-13-ov02e10-v4-0-211e3e6fae90@xxxxxxxxxx/
>
> Working for me included in this series:
>
> - USB
>    Both Type-C USB ports
>    Type-A port
>    Fingerprint reader
> - WiFi
> - Bluetooth
> - RGB Camera
> - Toucpad, keyboard
> - Display
>
> Working for me but not included:
> - Audio jack
> - Iris
>
> Not working:
> - Speaker output
>    Still WiP haven't touched this in a while
>
> - Battery
>    Dell has its own Embedded Controller likely from the x86 platform reused
>    on Qcom which we need to reverse engineer or get some information on to
>    make faster progress on.
>
> - cDSP
>    Haven't tried to bring this up.
>
> - EVA
>    No driver haven't tried it.
>
> - Bugs
>    Occasionally when resuming I get a fencing error with hyperlock and
>    freedreno, TBH it looks like something in the GPU or SMMU according to
>    Rob Clark: https://pastebin.com/AWjCyaap
>
>    Ath12k has been splatting for me up to 6.14 when removing a SSID.
>    I switched on ath12k debug when going to 6.15 and predictably couldn't
>    reproduce the bug, either because the timings have changed as a result
>    of Heisenbugging or because a fix has been slipped into ath12k.
>
>    Other than those two I'm pretty happy with this system.
>
>    The DTS is based on Aleksandrs Vinarskis XPS, Lenovo T14s and Qcom CRD.
>   
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

Hi,

Just noticed that the device name is misspelled in a few occasions, need 
to s/inspirion/inspiron/. DT filename is wrong, model name in DT is 
wrong, one of commit messages is wrong. Firmware paths and compatible in 
DT are correct.
Otherwise, is the plan to wait for CAMSS to land, and then land this 
one, or perhaps the rest of it can go in already? There is also Latitude 
that was recently submitted which is very similar, perhaps those should 
be unified (CC: Val), probably easier to do if Inspiron lands first.

Regards,
Alex

> ---
> Bryan O'Donoghue (3):
>        dt-bindings: arm: qcom: Add Dell Inspiron 14 Plus 7441
>        arm64: dts: qcom: Add support for X1E80100 Dell Inspirion 14 Plus 7441
>        arm64: dts: qcom: x1e80100-dell-inspiron14-7441: Switch on CAMSS RGB sensor
>
>   Documentation/devicetree/bindings/arm/qcom.yaml    |    1 +
>   arch/arm64/boot/dts/qcom/Makefile                  |    1 +
>   .../qcom/x1e80100-dell-inspirion-14-plus-7441.dts  | 1490 ++++++++++++++++++++
>   3 files changed, 1492 insertions(+)
> ---
> base-commit: f7570505263aff2b63142f0d68fa607cd60eb060
> change-id: 20250417-qcom-linux-arm64-for-6-16-dell-inspiron14p-ed68cd65ebad
>
> Best regards,