Re: [PATCH v13 2/6] rust: introduce module_param module

[Miguel Ojeda]

On Tue, Jul 1, 2025 at 5:43 PM Benno Lossin <lossin@xxxxxxxxxx> wrote:
>
> Ultimately this is something for Miguel to decide.

Only if you all cannot get to an agreement ;)

If Andreas wants to have it already added, then I would say just mark
it `unsafe` as Benno recommends (possibly with an overbearing
precondition), given it has proven subtle/forgettable enough and that,
if I understand correctly, it would actually become unsafe if someone
"just" added "reasonably-looking code" elsewhere.

That way we have an incentive to make it safe later on and, more
importantly, to think again about it when such a patch lands,
justifying it properly. And it could plausibly protect out-of-tree
users, too.

This is all assuming that we will not have many users of this added
right away (in a cycle or two), i.e. assuming it will be easy to
change callers later on (if only to remove the `unsafe {}`).

Cheers,
Miguel