Re: [PATCH v1 21/29] mm: rename PG_isolated to PG_movable_ops_isolated

[David Hildenbrand]

> >   PAGEFLAG(MovableOps, movable_ops, PF_NO_TAIL);
> > +/*
> > + * A movable_ops page has this flag set while it is isolated for migration.
> > + * This flag primarily protects against concurrent migration attempts.
> > + *
> > + * Once migration ended (success or failure), the flag is cleared. The
> > + * flag is managed by the migration core.
> > + */
> > +PAGEFLAG(MovableOpsIsolated, movable_ops_isolated, PF_NO_TAIL);
> >   #else
> >   PAGEFLAG_FALSE(MovableOps, movable_ops);
> > +PAGEFLAG_FALSE(MovableOpsIsolated, movable_ops_isolated);
> >   #endif
>
> Nit, but maybe worth sticking /* CONFIG_MIGRATION */ on else and endif? Not a
> huge block so maybe not massively important but just a thought!

Sure, why not (goes into the introducing patch) :)


--
Cheers,

David / dhildenb