Re: [RFC PATCH v7 05/37] KVM: lapic: Change lapic regs base address to void pointer

[Borislav Petkov]

On Tue, Jun 10, 2025 at 11:23:52PM +0530, Neeraj Upadhyay wrote:
> Change lapic regs base address from "char *" to "void *" in KVM
> lapic's set/reg helper functions. Pointer arithmetic for "void *"
> and "char *" operate identically. With "void *" there is less
> of a chance of doing the wrong thing, e.g. neglecting to cast and
> reading a byte instead of the desired apic reg size.

Please go through your commit messages and do

s/apic/APIC/g

s/reg/register/g in human-readable text. I know this is talking about code but
still - writing a commit message which reads like code is yucky.

And all those abbreviations. You have a mish-mash of all lower letters and all
caps and it reads weird.

Next patch too:

"... for use in Secure AVIC apic driver..." why not "APIC" as a real
abbreviation too?

"... to signify that it is part of apic api."

... as part of the APIC API.

And so on.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette