Re: [PATCH] netfs: Merge i_size update functions

[Christian Brauner]

On Thu, Jun 26, 2025 at 01:44:36PM +0100, David Howells wrote:
> Here's a follow up patch to the previous one, though this would be for next -
> and assuming it's okay to do the i_blocks update in the DIO case which it
> currently lacks.
> 
> David
> ---
> Netfslib has two functions for updating the i_size after a write: one for
> buffered writes into the pagecache and one for direct/unbuffered writes.
> However, what needs to be done is much the same in both cases, so merge
> them together.
> 
> This does raise one question, though: should updating the i_size after a
> direct write do the same estimated update of i_blocks as is done for
> buffered writes.
> 
> Also get rid of the cleanup function pointer from netfs_io_request as it's
> only used for direct write to update i_size; instead do the i_size setting
> directly from write collection.
> 
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> cc: Steve French <sfrench@xxxxxxxxx>
> cc: Paulo Alcantara <pc@xxxxxxxxxxxxx>
> cc: linux-cifs@xxxxxxxxxxxxxxx
> cc: netfs@xxxxxxxxxxxxxxx
> cc: linux-fsdevel@xxxxxxxxxxxxxxx
> ---

I have one big ask. Please please please put your comments after the
commit message --- separator. Otherwise git/b4 will take your top
comment as the commmit message and discard the actual commit message.