Re: [PATCH v2 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: document SM7635 ADSP & CDSP

[Krzysztof Kozlowski]

On Fri, Jun 27, 2025 at 08:55:43AM +0200, Luca Weiss wrote:
> Document the ADSP & CDSP remoteprocs on the SM7635 Platform.
> 
> Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> ---
>  .../bindings/remoteproc/qcom,sm8550-pas.yaml       | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> index 2dd479cf48217a0799ab4e4318026d8b93c3c995..44cc329be5067ab6cbaa0a467669cb3f55c7e714 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> @@ -18,6 +18,8 @@ properties:
>      oneOf:
>        - enum:
>            - qcom,sdx75-mpss-pas
> +          - qcom,sm7635-adsp-pas
> +          - qcom,sm7635-cdsp-pas

I don't understand why this is here and mpss and wpss are in other file.
It is supposed to be in one binding file, especiall that:

>            - qcom,sm8550-adsp-pas
>            - qcom,sm8550-cdsp-pas
>            - qcom,sm8550-mpss-pas
> @@ -165,6 +167,24 @@ allOf:
>            minItems: 5
>            maxItems: 5
>  
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,sm7635-adsp-pas
> +            - qcom,sm7635-cdsp-pas

it does not fit existing cases!

> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 6
> +          maxItems: 6
> +        interrupt-names:
> +          minItems: 6
> +          maxItems: 6
> +        memory-region:
> +          minItems: 2
> +          maxItems: 2
> +
>    - if:
>        properties:
>          compatible:
> @@ -185,6 +205,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - qcom,sm7635-adsp-pas
>                - qcom,sm8550-adsp-pas
>                - qcom,sm8650-adsp-pas
>                - qcom,sm8750-adsp-pas

sm6350 fits, doesn't it?

> @@ -239,6 +260,22 @@ allOf:
>              - const: mxc
>              - const: nsp
>  
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,sm7635-cdsp-pas
> +    then:
> +      properties:
> +        power-domains:
> +          items:
> +            - description: CX power domain
> +            - description: MX power domain
> +        power-domain-names:
> +          items:
> +            - const: cx
> +            - const: mx

And again this is like sm6350 :/

Best regards,
Krzysztof