Re: [PATCH v2 7/8] riscv: dts: spacemit: Enable PDMA0 on Banana Pi F3 and Milkv Jupiter

[Krzysztof Kozlowski]

On 01/07/2025 07:37, Guodong Xu wrote:
> Enable the PDMA0 on the SpacemiT K1-based Banana Pi F3 and Milkv Jupiter
> boards by setting its status to "okay".
> 
> Signed-off-by: Guodong Xu <guodong@xxxxxxxxxxxx>
> ---
> v2: added pdma0 enablement on Milkv Jupiter
> ---
>  arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts   | 4 ++++
>  arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> index fe22c747c5012fe56d42ac8a7efdbbdb694f31b6..39133450e07f2cb9cb2247dc0284851f8c55031b 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> @@ -45,3 +45,7 @@ &uart0 {
>  	pinctrl-0 = <&uart0_2_cfg>;
>  	status = "okay";
>  };
> +
> +&pdma0 {


Does not look like placed according to DTS coding style. What sort of
ordering Spacemit follows?



Best regards,
Krzysztof