Re: [PATCH net-next v2 0/9] net: Remove unused function parameters in skbuff.c

[Michal Luczaj]

On 7/1/25 03:18, Jakub Kicinski wrote:
> On Thu, 26 Jun 2025 10:33:33 +0200 Michal Luczaj wrote:
>> Couple of cleanup patches to get rid of unused function parameters around
>> skbuff.c, plus little things spotted along the way.
>>
>> Offshoot of my question in [1], but way more contained. Found by adding
>> "-Wunused-parameter -Wno-error" to KBUILD_CFLAGS and grepping for specific
>> skbuff.c warnings.
> 
> I feel a little ambivalent about the removal of the flags arguments.
> I understand that they are unused now, but theoretically the operation
> as a whole has flags so it's not crazy to pass them along.. Dunno.

I suspect you can say the same about @gfp. Even though they've both became
irrelevant for the functions that define them. But I understand your
hesitation. Should I post v3 without this/these changes?

What's netdev's stance on using __always_unused in such cases?

Thanks,
Michal