Re: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths

[Dan Carpenter]

On Tue, Jul 01, 2025 at 12:39:24AM +0000, Romli, Khairul Anuar wrote:
> > On Mon, Jun 30, 2025 at 05:11:56PM +0800,
> > khairul.anuar.romli@xxxxxxxxxx wrote:
> > > From: Khairul Anuar Romli <khairul.anuar.romli@xxxxxxxxxx>
> > >
> > > Remove incorrect checks on cqspi->rx_chan that cause driver breakage
> > > during failure cleanup. Ensure proper resource freeing on the success
> > > path when operating in cqspi->use_direct_mode, preventing leaks and
> > > improving stability.
> > >
> > > Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@xxxxxxxxxx>
> > 
> > Thanks.
> > 
> > Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > 
> > Mark asked me to fix this and I wrote a fix but apparently I didn't hit send
> > because it's still in my outbox.  Sorry about that.  :(
> > 
> > regards,
> > dan carpenter
> 
> Sorry for sending the fix on your behalf.

No no.  You did the right thing.  It's me who messed up.

regards,
dan carpenter