Re: [PATCH] Input: mtk-pmic-keys: Fix null pointer dereference when no compatible data

[Dmitry Torokhov]

On Mon, Jun 30, 2025 at 03:23:36PM -0700, Easwar Hariharan wrote:
> On 6/30/2025 2:46 PM, Dmitry Torokhov wrote:
> > On Mon, Jun 30, 2025 at 01:18:40PM -0700, Easwar Hariharan wrote:
> >>
> >> Also, it may make sense to CC: stable@xxxxxxxxxxxxxxx for backports
> > 
> > What for? Stable does not need a patch papering over an oops, it needs a
> > patch making the keypad working on the affected device.
> > 
> > Thanks.
> > 
> 
> I don't have a stake either way, it was simply a suggestion, since it qualifies
> IMHO, per https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html,
> the patch "...fixes a problem like an oops..."
> 
> The proper fix might well be, as Nicolas suggested, adding the required compatibles.

It looks like it is not only about adding compatibles but actually
adding proper support for the missed variants...

Thanks.

-- 
Dmitry