Re: [PATCH v4 3/4] PCI: dwc: Add debugfs support for PTM context

From: Bjorn Helgaas
Date: Mon Jun 30 2025 - 16:52:09 EST


On Tue, Jun 17, 2025 at 06:12:10PM -0500, Bjorn Helgaas wrote:
> On Mon, May 05, 2025 at 07:54:41PM +0530, Manivannan Sadhasivam wrote:
> > Synopsys Designware PCIe IPs support PTM capability as defined in the PCIe
> > spec r6.0, sec 6.21. The PTM context information is exposed through Vendor
> > Specific Extended Capability (VSEC) registers on supported controller
> > implementation.
>
> > +const struct pcie_ptm_ops dw_pcie_ptm_ops = {
>
> Sparse complains:
>
> CHECK drivers/pci/controller/dwc/pcie-designware-debugfs.c
> drivers/pci/controller/dwc/pcie-designware-debugfs.c:868:27: warning: symbol 'dw_pcie_ptm_ops' was not declared. Should it be static?
>
> I should have noticed this earlier, sorry. As of v6.16-rc1, this is
> now 852a1fdd34a8 ("PCI: dwc: Add debugfs support for PTM context")
> upstream.

Keeping this warm so we remember to fix it eventually.