Re: [PATCH v13 5/5] serial: sh-sci: Add support for RZ/T2H SCI

[Lad, Prabhakar]

Hi Greg,

Thank you for the review.

On Sun, Jun 29, 2025 at 1:28 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sat, Jun 28, 2025 at 12:57:15PM +0100, Prabhakar wrote:
> > +EXPORT_SYMBOL(sci_port_enable);
>
> EXPORT_SYMBOL_GPL() perhaps?  (sorry, I have to ask).
>
I agree EXPORT_SYMBOL_GPL() should have been used as module license is GPL.

> Also, why not limit this to just this one other driver that you want to
> use it with the proper namespace usage instead?
>
Good point, I will switch to using namespaces.

Cheers,
Prabhakar