Re: [PATCH v1 2/4] mm: smaller folio_pte_batch() improvements
From: Zi Yan
Date: Mon Jun 30 2025 - 13:40:56 EST
On 27 Jun 2025, at 7:55, David Hildenbrand wrote:
> Let's clean up a bit:
>
> (1) No need for start_ptep vs. ptep anymore, we can simply use ptep
>
> (2) Let's switch to "unsigned int" for everything
>
> (3) We can simplify the code by leaving the pte unchanged after the
> pte_same() check.
>
> (4) Clarify that we should never exceed a single VMA; it indicates a
> problem in the caller.
>
> No functional change intended.
>
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> ---
> mm/internal.h | 37 +++++++++++++++----------------------
> 1 file changed, 15 insertions(+), 22 deletions(-)
>
LGTM. Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>
Best Regards,
Yan, Zi