Re: [char-misc-next v2 4/5] mei: more prints with client prefix

[Greg Kroah-Hartman]

On Mon, Jun 30, 2025 at 12:19:41PM +0300, Alexander Usyskin wrote:
> Use client-aware print macro instead of
> usual device print in more places.

Why?  This changes the output of the driver.

> 
> Signed-off-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> ---
>  drivers/misc/mei/hbm.c       | 14 ++++-----
>  drivers/misc/mei/interrupt.c |  2 +-
>  drivers/misc/mei/main.c      | 55 +++++++++++++++++-------------------
>  3 files changed, 34 insertions(+), 37 deletions(-)
> 
> diff --git a/drivers/misc/mei/hbm.c b/drivers/misc/mei/hbm.c
> index 026b1f686c16..4fe9a2752d43 100644
> --- a/drivers/misc/mei/hbm.c
> +++ b/drivers/misc/mei/hbm.c
> @@ -510,7 +510,7 @@ int mei_hbm_cl_notify_req(struct mei_device *dev,
>  
>  	ret = mei_hbm_write_message(dev, &mei_hdr, &req);
>  	if (ret)
> -		dev_err(dev->dev, "notify request failed: ret = %d\n", ret);
> +		cl_err(dev, cl, "notify request failed: ret = %d\n", ret);

Why do you have a mei-specific debug printk macro anyway?  You really
shouldn't do that :(

This feels like a step backwards.

thanks,

greg k-h