Re: [PATCH v3 1/2] dt-bindings: display: panel: document Samsung S6E8AA5X01 panel driver

[Kaustabh Chakraborty]

On 2025-06-30 15:29, Neil Armstrong wrote:
> On 25/06/2025 14:41, Kaustabh Chakraborty wrote:
> > Samsung S6E8AA5X01 is an AMOLED MIPI DSI panel controller. Document 
> > the
> > compatible and devicetree properties of this panel driver. Timings are
> > provided through the devicetree node as panels are available in
> > different sizes.
>
> Wait, why ? Why not multiple compatibles ?

The panel dimensions is the only thing which differs. The model name,
controller, registers, and functionality are supposedly all similar, so
I believe this is fine...

> Neil
>
> > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx>
> > ---
> >   .../bindings/display/panel/samsung,s6e8aa5x01.yaml | 78 
> > ++++++++++++++++++++++
> >   1 file changed, 78 insertions(+)
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa5x01.yaml 
> > b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa5x01.yaml
> > new file mode 100644
> > index 
> > 0000000000000000000000000000000000000000..23dae6e961ae01c99de93bf4b4a067f2953f8edf
> > --- /dev/null
> > +++ 
> > b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa5x01.yaml
> > @@ -0,0 +1,78 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: 
> > http://devicetree.org/schemas/display/panel/samsung,s6e8aa5x01.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Samsung S6E8AA5X01 display panel controller
> > +
> > +maintainers:
> > +  - Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: samsung,s6e8aa5x01
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  vdd-supply:
> > +    description: core voltage supply
> > +
> > +  vci-supply:
> > +    description: voltage supply for analog circuits
> > +
> > +  reset-gpios: true
> > +  width-mm: true
> > +  height-mm: true
> > +  panel-timing: true
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - width-mm
> > +  - height-mm
> > +  - panel-timing
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    dsi {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        panel@0 {
> > +            compatible = "samsung,s6e8aa5x01";
> > +            reg = <0>;
> > +
> > +            vdd-supply = <&panel_vdd_reg>;
> > +            vci-supply = <&panel_vci_reg>;
> > +
> > +            reset-gpios = <&gpd3 4 GPIO_ACTIVE_HIGH>;
> > +
> > +            width-mm = <62>;
> > +            height-mm = <128>;
> > +
> > +            panel-timing {
> > +                clock-frequency = <73094400>;
> > +
> > +                hactive = <720>;
> > +                hsync-len = <2>;
> > +                hfront-porch = <62>;
> > +                hback-porch = <26>;
> > +
> > +                vactive = <1480>;
> > +                vsync-len = <2>;
> > +                vfront-porch = <12>;
> > +                vback-porch = <10>;
> > +            };
> > +        };
> > +    };
> > +
> > +...