Re: [PATCH net-next v1 1/2] selftests: pp-bench: remove unneeded linux/version.h

[Ilias Apalodimas]

On Fri, 27 Jun 2025 at 23:05, Mina Almasry <almasrymina@xxxxxxxxxx> wrote:
>
> linux/version.h was used by the out-of-tree version, but not needed in
> the upstream one anymore.
>
> While I'm at it, sort the includes.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506271434.Gk0epC9H-lkp@xxxxxxxxx/
> Signed-off-by: Mina Almasry <almasrymina@xxxxxxxxxx>
> ---
>  .../selftests/net/bench/page_pool/bench_page_pool_simple.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>

>
> diff --git a/tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c b/tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c
> index f183d5e30dc6..1cd3157fb6a9 100644
> --- a/tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c
> +++ b/tools/testing/selftests/net/bench/page_pool/bench_page_pool_simple.c
> @@ -5,15 +5,12 @@
>   */
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> +#include <linux/interrupt.h>
> +#include <linux/limits.h>
>  #include <linux/module.h>
>  #include <linux/mutex.h>
> -
> -#include <linux/version.h>
>  #include <net/page_pool/helpers.h>
>
> -#include <linux/interrupt.h>
> -#include <linux/limits.h>
> -
>  #include "time_bench.h"
>
>  static int verbose = 1;
>
> base-commit: 8efa26fcbf8a7f783fd1ce7dd2a409e9b7758df0
> --
> 2.50.0.727.gbf7dc18ff4-goog
>