Re: [PATCH v14 21/32] fs/resctrl: Pass entire struct rdtgroup rather than passing individual members

[Moger, Babu]

Hi Reinette,

On 6/24/2025 11:18 PM, Reinette Chatre wrote:
> Hi Babu,
> 
> On 6/13/25 2:05 PM, Babu Moger wrote:
>> Reading the monitoring data requires RMID, CLOSID, and event ID, among
>> other parameters. These are passed individually, resulting in architecture
> 
> It is not clear how "event ID" and "other parameters" are relevant to this
> change since (in this context) it is only RMID and CLOSID that can be
> found in rdtgroup.
> 
>> specific function calls.
> 
> Could you please elaborate what you meant with: "These are passed individually,
> resulting in architecture specific function calls."?

Rephrased the whole changelog.

"fs/resctrl: Pass the full rdtgroup structure instead of individual RMID
and CLOSID

The functions resctrl_arch_reset_rmid() and resctrl_arch_rmid_read()
require several parameters, including RMID and CLOSID. Currently, RMID and
CLOSID are passed individually, even though they are available within the
rdtgroup structure.

Refactor the code to pass a pointer to struct rdtgroup instead of
individual members in preparation for this requirement.

Additionally, when "mbm_event" counter assignment mode is enabled, a
counter ID is required to read the event. The counter ID is obtained
through mbm_cntr_get(), which expects a struct rdtgroup pointer."


Thanks
Babu