Re: [PATCH net-next v2] ptp: add Alibaba CIPU PTP clock driver

[Richard Cochran]

On Mon, Jun 30, 2025 at 07:23:49PM +0800, Wen Gu wrote:

> In ptp_clock.c, ops.clock_settime() is assigned to ptp_clock_settime(),
> and it will call ptp->info->settime64() without checks. So I think these
> 'return -EOPNOTSUPP' functions are needed. Did I miss something?

Right, for the essential clock related callbacks, stubs are expected
by the ptp class layer.

Some of the newer, non-essential clock methods do indeed check the
function pointer, simply to accommodate existing drivers.

Thanks,
Richard