Re: [PATCH v2 drm-dp 08/10] drm/hisilicon/hibmc: fix no showing when no connectors connected

[Yongbang Shi]

> On Fri, Jun 20, 2025 at 05:31:02PM +0800, Yongbang Shi wrote:
> > From: Baihan Li <libaihan@xxxxxxxxxx>
> >
> > Our chip support KVM over IP feature, so hibmc driver need to support
> > displaying without any connectors plugged in. Deleting the detect_ctx()
> > of VGA to make it connected when no connector is detected.
> I think, there is more than that. Please see how AST driver handles the
> same issue. I think you need something similar.

Okay, thanks for your advice!


> > Fixes: 4c962bc929f1 ("drm/hisilicon/hibmc: Add vga connector detect functions")
> > Signed-off-by: Baihan Li <libaihan@xxxxxxxxxx>
> > Signed-off-by: Yongbang Shi <shiyongbang@xxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> > index 841e81f47b68..953474d04b5c 100644
> > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> > @@ -60,7 +60,6 @@ static void hibmc_connector_destroy(struct drm_connector *connector)
> >   static const struct drm_connector_helper_funcs
> >   	hibmc_connector_helper_funcs = {
> >   	.get_modes = hibmc_connector_get_modes,
> > -	.detect_ctx = drm_connector_helper_detect_from_ddc,
> >   };
> >   
> >   static const struct drm_connector_funcs hibmc_connector_funcs = {
> > --
> > 2.33.0