Re: [RFC PATCH 3/4] usb: core: Plug the usb authentication capability
From: Oliver Neukum
Date: Mon Jun 30 2025 - 09:15:10 EST
Hi,
On 30.06.25 14:34, Nicolas Bouchinet wrote:
Hi Olivier,
Thank you for your review.
Indeed our current implementation of the usb authentication is still a bit
crude.
that is understood, but the question here is not just whether they
are crude, but whether they are sensible. You are putting the use of
the authentication code in usb_new_device(). This means that the admin
cannot change the settings of currently connected devices. It would seem
to me that the check should go into usb_claim_interface().
Regards
Oliver