Re: [PATCH v4 14/22] x86/mce: Separate global and per-CPU quirks

[Yazen Ghannam]

On Fri, Jun 27, 2025 at 02:02:22PM +0300, Nikolay Borisov wrote:
> 
> 
> On 6/24/25 17:16, Yazen Ghannam wrote:
> > Many quirks are global configuration settings and a handful apply to
> > each CPU.
> > 
> > Move the per-CPU quirks to vendor init to execute them on each online
> > CPU. Set the global quirks during BSP-only init so they're only executed
> > once and early.
> > 
> > Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>
> > Tested-by: Tony Luck <tony.luck@xxxxxxxxx>
> > Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>
> > Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> 
> 
> After this patch the code ends up with 2 sets of quirk functions with very
> confusing names:
> 
> amd_apply_quirks/apply_quirks_amd
> intel_apply_quirks/apply_quirks_intel
> 
> 
> Better naming convention would be something along the lines of:
> 
> amd_apply_global_quirks/amd_apply_cpu_quirks and the same for intel.
> 

Yes, good point. I'll make this change.

Thanks,
Yazen