Re: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths

[Santhosh Kumar K]

Hello Khairul,

On 30/06/25 14:41, khairul.anuar.romli@xxxxxxxxxx wrote:
> From: Khairul Anuar Romli <khairul.anuar.romli@xxxxxxxxxx>
>
> Remove incorrect checks on cqspi->rx_chan that cause driver breakage
> during failure cleanup. Ensure proper resource freeing on the success
> path when operating in cqspi->use_direct_mode, preventing leaks and
> improving stability.
>
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@xxxxxxxxxx>

Please add 'Fixes' tag and add stable in cc.

Regards,
Santhosh.

> ---
>   drivers/spi/spi-cadence-quadspi.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
> index aa1932ba17cb..d3c78f59b22c 100644
> --- a/drivers/spi/spi-cadence-quadspi.c
> +++ b/drivers/spi/spi-cadence-quadspi.c
> @@ -1960,11 +1960,6 @@ static int cqspi_probe(struct platform_device *pdev)
>   
>   	pm_runtime_enable(dev);
>   
> -	if (cqspi->rx_chan) {
> -		dma_release_channel(cqspi->rx_chan);
> -		goto probe_setup_failed;
> -	}
> -
>   	pm_runtime_set_autosuspend_delay(dev, CQSPI_AUTOSUSPEND_TIMEOUT);
>   	pm_runtime_use_autosuspend(dev);
>   	pm_runtime_get_noresume(dev);