Re: [PATCHv7 13/16] x86/traps: Handle LASS thrown #SS

From: Kirill A. Shutemov
Date: Mon Jun 30 2025 - 05:50:26 EST


On Mon, Jun 30, 2025 at 09:30:27AM +0100, David Laight wrote:
> On Fri, 27 Jun 2025 13:31:44 +0300
> "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx> wrote:
>
> > On Thu, Jun 26, 2025 at 10:57:47AM -0700, Xin Li wrote:
> > > On 6/25/2025 5:51 AM, Kirill A. Shutemov wrote:
> > > > LASS throws a #GP for any violations except for stack register accesses,
> > > > in which case it throws a #SS instead. Handle this similarly to how other
> > > > LASS violations are handled.
> > > >
> > > > In case of FRED, before handling #SS as LASS violation, kernel has to
> > > > check if there's a fixup for the exception. It can address #SS due to
> > > > invalid user context on ERETU[1]. See 5105e7687ad3 ("x86/fred: Fixup
> > >
> > > Forgot to put the link to [1]? Maybe just remove "[1]"?
> >
> > I will add the link. It is important context.
>
> Will the link still be valid in 5 years time when someone
> is looking back at the changes?

Re-reading the commit message I wrote, it is obvious that I reconsidered
putting the link and referenced commit instead.

I will drop [1];

--
Kiryl Shutsemau / Kirill A. Shutemov