Re: [PATCH v2 05/11] iio: adc: ad_sigma_delta: audit included headers

From: Andy Shevchenko
Date: Mon Jun 30 2025 - 05:02:45 EST


On Fri, Jun 27, 2025 at 06:40:01PM -0500, David Lechner wrote:
> Drop linux/iio/sysfs.h since it is unused and replace linux/kernel.h
> with more explicit headers. There are a couple of other headers added
> weren't covered by kernel.h, like linux/gpio/consumer.h that are added
> since the module makes used of those APIs as well.

s/used/use/

> Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>

...

> #include <linux/align.h>
> +#include <linux/bitmap.h>
> #include <linux/bitops.h>

bitops.h is implied by bitmap.h, but I'm fine with this being left untouched.

> +#include <linux/cleanup.h>
> +#include <linux/completion.h>
> #include <linux/device.h>
> #include <linux/err.h>
> +#include <linux/export.h>
> +#include <linux/find.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/interrupt.h>
> -#include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/property.h>
> #include <linux/slab.h>
> #include <linux/spi/spi.h>
> +#include <linux/spinlock.h>
> +#include <linux/string.h>
> #include <linux/types.h>
> #include <linux/unaligned.h>

--
With Best Regards,
Andy Shevchenko