Re: [PATCH v2 0/3] platform/x86: think-lmi: Fix resource cleanup flaws
From: Ilpo Järvinen
Date: Mon Jun 30 2025 - 04:55:53 EST
On Sat, 28 Jun 2025, Kurt Borja wrote:
> Hi all,
>
> First patch is a prerequisite in order to avoid NULL pointer
> dereferences in error paths. Then two fixes follow.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
Please send v3 with stable Cc tags in all these so that this dependency
gets automatically handled (as per documentation).
I'll apply this through the fixes branch but I can deal with the removal
of the lenovo/ folder from the file names myself while applying.
> Signed-off-by: Kurt Borja <kuurtb@xxxxxxxxx>
> ---
> Changes in v2:
>
> [PATCH 02]
> - Remove kobject_del() and commit message remark. It turns out it's
> optional to call this (my bad)
> - Leave only one fixes tag. The other two are not necessary.
>
> - Link to v1: https://lore.kernel.org/r/20250628-lmi-fix-v1-0-c6eec9aa3ca7@xxxxxxxxx
>
> ---
> Kurt Borja (3):
> platform/x86: think-lmi: Create ksets consecutively
> platform/x86: think-lmi: Fix kobject cleanup
> platform/x86: think-lmi: Fix sysfs group cleanup
>
> drivers/platform/x86/lenovo/think-lmi.c | 90 +++++++++++----------------------
> 1 file changed, 30 insertions(+), 60 deletions(-)
> ---
> base-commit: 73f0f2b52c5ea67b3140b23f58d8079d158839c8
> change-id: 20250628-lmi-fix-98143b10d9fd
>
--
i.