Re: [PATCH v2 5/8] dt-bindings: vendor-prefixes: Add Wuxi i-Core Electronics

[Christian Hewitt]

> On 30 Jun 2025, at 12:19 pm, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> 
> Hi Jean-François,
> 
> On Sun, 29 Jun 2025 at 15:00, Jean-François Lessard
> <jefflessard3@xxxxxxxxx> wrote:
>> Assign vendor prefix "icore", based on their domain name.
>> 
>> Signed-off-by: Jean-François Lessard <jefflessard3@xxxxxxxxx>
> 
> Thanks for your patch!
> 
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> @@ -694,6 +694,8 @@ patternProperties:
>>     description: International Business Machines (IBM)
>>   "^ibm,.*":
>>     description: International Business Machines (IBM)
>> +  "^icore,.*":
>> +    description: Wuxi i-Core Electronics Co., Ltd.
> 
> This sounds a bit too generic to me.  What is the domain name?

Their domain/website is http://www.i-core.cn/en/ and i-Core is used
as the watermark in their datasheets [0]. We’ve thought to drop the
hyphen and use plain ‘icore’ to avoid future typos.

[0] https://github.com/jefflessard/tm16xx-display/blob/main/datasheets/AiP1628.pdf

CH.

>>   "^icplus,.*":
>>     description: IC Plus Corp.
>>   "^idt,.*":
>> --
> 
> Gr{oetje,eeting}s,
> 
>                        Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                -- Linus Torvalds