Re: [PATCH v2 09/11] ARM: dts: mediatek: add basic support for MT6572 SoC

[AngeloGioacchino Del Regno]

Il 26/06/25 10:54, Max Shevchenko via B4 Relay ha scritto:
> From: Max Shevchenko <wctrl@xxxxxxxxx>
>
> Add basic support for the MediaTek MT6572 SoC.
>
> Signed-off-by: Max Shevchenko <wctrl@xxxxxxxxx>
> ---
>   arch/arm/boot/dts/mediatek/mt6572.dtsi | 109 +++++++++++++++++++++++++++++++++
>   1 file changed, 109 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mediatek/mt6572.dtsi b/arch/arm/boot/dts/mediatek/mt6572.dtsi
> new file mode 100644
> index 0000000000000000000000000000000000000000..b4fa376619a58cacd33ef556f80c1a4f7126c4f5
> --- /dev/null
> +++ b/arch/arm/boot/dts/mediatek/mt6572.dtsi
> @@ -0,0 +1,109 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2025 Max Shevchenko <wctrl@xxxxxxxxx>
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +/ {
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +	compatible = "mediatek,mt6572";

Please, remove this compatible as it's anyway going to be overridden in all of the
board specific devicetrees; after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Cheers!
Angelo