Re: [PATCH 66/66] kconfig: gconf: show GTK version in About dialog

[Randy Dunlap]

On 6/24/25 8:05 AM, Masahiro Yamada wrote:
> Likewise xconfig, it is useful to display the GTK version in the About
> dialog.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

> ---
> 
>  scripts/kconfig/gconf.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index 5b1b468e782d..7340407e4d6e 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -579,7 +579,11 @@ static void on_about1_activate(GtkMenuItem *menuitem, gpointer user_data)
>  	dialog = gtk_message_dialog_new(GTK_WINDOW(main_wnd),
>  					GTK_DIALOG_DESTROY_WITH_PARENT,
>  					GTK_MESSAGE_INFO,
> -					GTK_BUTTONS_CLOSE, "%s", about_text);
> +					GTK_BUTTONS_CLOSE, "%s\nGTK version: %d.%d.%d",
> +					about_text,
> +					gtk_get_major_version(),
> +					gtk_get_minor_version(),
> +					gtk_get_micro_version());
>  	gtk_dialog_run(GTK_DIALOG(dialog));
>  	gtk_widget_destroy(dialog);
>  }

-- 
~Randy