Re: [PATCH 03/66] kconfig: qconf: show selected choice in the Value column

[Randy Dunlap]

On 6/24/25 8:04 AM, Masahiro Yamada wrote:
> It is useful to display the selected choice's value in the Value column.

(instead of 'N', useless)


Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Nice, thanks.

> 
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
> 
>  scripts/kconfig/qconf.cc | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
> index 546738a5c3b1..68640e507ec4 100644
> --- a/scripts/kconfig/qconf.cc
> +++ b/scripts/kconfig/qconf.cc
> @@ -127,6 +127,9 @@ void ConfigItem::updateMenu(void)
>  		goto set_prompt;
>  	case M_CHOICE:
>  		setIcon(promptColIdx, QIcon());
> +		sym = sym_calc_choice(menu);
> +		if (sym)
> +			setText(dataColIdx, sym->name);
>  		goto set_prompt;
>  	default:
>  		;
> @@ -189,7 +192,11 @@ void ConfigItem::testUpdateMenu(void)
>  	if (!menu)
>  		return;
>  
> -	sym_calc_value(menu->sym);
> +	if (menu->type == M_CHOICE)
> +		sym_calc_choice(menu);
> +	else
> +		sym_calc_value(menu->sym);
> +
>  	if (menu->flags & MENU_CHANGED) {
>  		/* the menu entry changed, so update all list items */
>  		menu->flags &= ~MENU_CHANGED;

-- 
~Randy