Re: [PATCH] platform/x86: dell-wmi-sysman: Fix WMI data block retrieval in sysfs callbacks

[Kurt Borja]

On Sun Jun 29, 2025 at 8:37 PM -03, Armin Wolf wrote:
> Am 29.06.25 um 20:33 schrieb Kurt Borja:
>
>> After retrieving WMI data blocks in sysfs callbacks, check for the
>> validity of them before dereferencing their content.
>>
>> Reported-by: Jan Graczyk <jangraczyk@xxxxxxxx>
>> Closes: https://lore.kernel.org/r/CAHk-=wgMiSKXf7SvQrfEnxVtmT=QVQPjJdNjfm3aXS7wc=rzTw@xxxxxxxxxxxxxx/
>> Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
>> Suggested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Kurt Borja <kuurtb@xxxxxxxxx>
>> ---
>>   drivers/platform/x86/dell/dell-wmi-sysman/dell-wmi-sysman.h    | 7 +++++++
>>   drivers/platform/x86/dell/dell-wmi-sysman/enum-attributes.c    | 5 +++--
>>   drivers/platform/x86/dell/dell-wmi-sysman/int-attributes.c     | 5 +++--
>>   drivers/platform/x86/dell/dell-wmi-sysman/passobj-attributes.c | 5 +++--
>>   drivers/platform/x86/dell/dell-wmi-sysman/string-attributes.c  | 5 +++--
>>   drivers/platform/x86/dell/dell-wmi-sysman/sysman.c             | 8 ++++----
>>   6 files changed, 23 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/dell-wmi-sysman.h b/drivers/platform/x86/dell/dell-wmi-sysman/dell-wmi-sysman.h
>> index 3ad33a094588c6a258786a02f952eaa6bf953234..792e7d865bfb1cfc13b59c90ddf7de47feff408f 100644
>> --- a/drivers/platform/x86/dell/dell-wmi-sysman/dell-wmi-sysman.h
>> +++ b/drivers/platform/x86/dell/dell-wmi-sysman/dell-wmi-sysman.h
>> @@ -89,6 +89,13 @@ extern struct wmi_sysman_priv wmi_priv;
>>   
>>   enum { ENUM, INT, STR, PO };
>>   
>> +enum {
>> +	ENUM_MIN_ELEMENTS	= 8,
>> +	INT_MIN_ELEMENTS	= 9,
>> +	STR_MIN_ELEMENTS	= 8,
>> +	PO_MIN_ELEMENTS		= 4,
>> +};
>
> Hi,
>
> are you sure that this works? I suggest we use defines instead as ENUM_MIN_ELEMENTS has the same value as STR_MIN_ELEMENTS.

Oh - I wrote that without thinking...

I'm pretty sure it works, but I'll go with defines anyway.

>
> For the rest:
>
> Reviewed-by: Armin Wolf <W_Armin@xxxxxx>

Thanks!


-- 
 ~ Kurt