Re: [PATCH 1/5] media: i2c: imx214: Remove unneeded parentheses

From: Laurent Pinchart
Date: Sun Jun 29 2025 - 12:57:31 EST


On Sun, Jun 29, 2025 at 04:49:20PM +0200, André Apitzsch via B4 Relay wrote:
> From: André Apitzsch <git@xxxxxxxxxxx>
>
> The parentheses are not needed to calculate bit_rate_mbps.
>
> Signed-off-by: André Apitzsch <git@xxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
> drivers/media/i2c/imx214.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
> index a0cef9e61b41be8ea76a6d6e4b8c9fc4060cfa0f..8e9b5c9c93b0888f3d6be857168711edaf050db3 100644
> --- a/drivers/media/i2c/imx214.c
> +++ b/drivers/media/i2c/imx214.c
> @@ -1029,8 +1029,8 @@ static int imx214_start_streaming(struct imx214 *imx214)
> return ret;
> }
>
> - bit_rate_mbps = (imx214->pll.pixel_rate_csi / 1000000)
> - * imx214->pll.bits_per_pixel;
> + bit_rate_mbps = imx214->pll.pixel_rate_csi / 1000000
> + * imx214->pll.bits_per_pixel;
> ret = cci_write(imx214->regmap, IMX214_REG_REQ_LINK_BIT_RATE,
> IMX214_LINK_BIT_RATE_MBPS(bit_rate_mbps), NULL);
> if (ret) {

--
Regards,

Laurent Pinchart