[PATCH v7] staging: media: atomisp: code style cleanup series
From: LiangCheng Wang
Date: Sun Jun 29 2025 - 07:31:15 EST
This series applies clang-format and fixes all checkpatch.pl-reported ERRORs in the AtomISP driver, excluding the i2c directory as advised by maintainers.
The changes include:
- Applying clang-format (excluding drivers/staging/media/i2c)
- Removing unnecessary parentheses in return statements
- Removing unnecessary zero-initialized globals
- Fixing space issues after unary minus operators
- Wrapping complex macro values in parentheses
- These patches focus solely on mechanical style cleanups with no functional changes.
- WARNINGs reported by checkpatch.pl were intentionally left for future work to keep each patch clear and manageable.
The full series and corresponding commits are also available in my public Git repository:
https://github.com/lc-wang/linux/tree/b4/atomisp
To: Hans de Goede <hansg@xxxxxxxxxx>
To: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
To: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
To: Andy Shevchenko <andy@xxxxxxxxxx>
To: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
To: Nathan Chancellor <nathan@xxxxxxxxxx>
To: Nick Desaulniers <nick.desaulniers+lkml@xxxxxxxxx>
To: Bill Wendling <morbo@xxxxxxxxxx>
To: Justin Stitt <justinstitt@xxxxxxxxxx>
Cc: linux-media@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: linux-staging@xxxxxxxxxxxxxxx
Cc: llvm@xxxxxxxxxxxxxxx
---
Changes in v7:
- Split previous monolithic patch into multiple smaller patches
- Applied clang-format to entire driver excluding i2c directory
- Fixed checkpatch.pl-reported ERRORs (parentheses in macros, unnecessary return parentheses, zero-initialized globals, spaces after unary minus)
- Left WARNINGS untouched for future cleanup
- No functional logic changes
- Link to v6: https://lore.kernel.org/r/20250627-bar-v6-1-b22b5ea3ced0@xxxxxxxxx
Changes in v6:
- Applied clang-format across the entire AtomISP driver
- Fixed all checkpatch.pl-reported ERRORs
- Added explanation of tooling and scope
- No functional logic modified
- Moved 'Suggested-by' and 'Link' tags above Signed-off-by
- Link to v5: https://lore.kernel.org/r/20250625-bar-v5-1-db960608b607@xxxxxxxxx
Changes in v5:
- Replaced space-based indentation with tabs in output_1.0 directory
- Used checkpatch.pl and grep to identify formatting issues
- No functional changes made
- This patch is now focused solely on tab/space issues
- Link to v4: https://lore.kernel.org/r/20250624-bar-v4-1-9f9f9ae9f868@xxxxxxxxx
Changes in v4:
- Moved assignment operator '=' to the same line for static struct definitions
- Remove unnecessary line breaks in function definitions
- Update commit message to reflect all the coding style fixes
- Link to v3: https://lore.kernel.org/r/20250622-bar-v3-1-4cc91ef01c3a@xxxxxxxxx
Changes in v3:
- Removed extra spaces between type and asterisk (e.g., `*to`) in function
declarations, as pointed out by Andy Shevchenko
- Update commit message to reflect all the coding style fixes
- Link to v2: https://lore.kernel.org/r/20250621-bar-v2-1-4e6cfc779614@xxxxxxxxx
Changes in v2:
- Fix patch subject prefix to "staging: media: atomisp:" to comply with media CI style.
- No other functional changes.
Link to v1: https://lore.kernel.org/r/20250621-bar-v1-1-5a3e7004462c@xxxxxxxxx
--- b4-submit-tracking ---
# This section is used internally by b4 prep for tracking purposes.
{
"series": {
"revision": 7,
"change-id": "20250621-bar-573b8b40fb80",
"prefixes": [],
"history": {
"v1": [
"20250621-bar-v1-1-5a3e7004462c@xxxxxxxxx"
],
"v2": [
"20250621-bar-v2-1-4e6cfc779614@xxxxxxxxx"
],
"v3": [
"20250622-bar-v3-1-4cc91ef01c3a@xxxxxxxxx"
],
"v4": [
"20250624-bar-v4-1-9f9f9ae9f868@xxxxxxxxx"
],
"v5": [
"20250625-bar-v5-1-db960608b607@xxxxxxxxx"
],
"v6": [
"20250627-bar-v6-1-b22b5ea3ced0@xxxxxxxxx"
]
}
}
}
--
2.43.0