Re: [PATCH v3 2/2] e1000e: ignore factory-default checksum value on TGP platform

[David Laight]

On Wed, 25 Jun 2025 15:05:01 +0200
Jacek Kowalski <jacek@xxxxxxxxxxx> wrote:

> >>>> +#define NVM_CHECKSUM_FACTORY_DEFAULT 0xFFFF  
> >>>
> >>> Perhaps it is too long, but I liked Vlad's suggestion of naming this
> >>> NVM_CHECKSUM_WORD_FACTORY_DEFAULT.  
> 
> So the proposals are:
> 
> 1. NVM_CHECKSUM_WORD_FACTORY_DEFAULT
> 2. NVM_CHECKSUM_FACTORY_DEFAULT
> 3. NVM_CHECKSUM_INVALID
> 4. NVM_CHECKSUM_MISSING
> 5. NVM_CHECKSUM_EMPTY
> 6. NVM_NO_CHECKSUM
> 
> Any other contenders?
> 

0xffff

With a comment saying some manufacturers don't calculate the checksum.
Then you don't needs to search the definition to find out what is going on.

	David