Re: [PATCH v3] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations
From: Vincent Mailhol
Date: Sun Jun 29 2025 - 03:20:16 EST
On 28/06/2025 at 16:19, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sat, 28 Jun 2025 08:56:51 +0200
Your patch doesn't pass the ./script/checkpath.pl script :(
WARNING: From:/Signed-off-by: email address mismatch: 'From: Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx>' != 'Signed-off-by: Markus Elfring
<Markus.Elfring@xxxxxx>'
total: 0 errors, 1 warnings, 0 checks, 21 lines checked
Please use the same email address:
- To send the patch
- For the patch author
- For the Signed-off-by tag
> * Reuse existing functionality from usb_endpoint_is_bulk_in()
> and usb_endpoint_is_bulk_out() instead of keeping duplicate source code.
>
> * Omit two comment lines which became redundant with this refactoring.
>
> The source code was transformed by using the Coccinelle software.
>
> Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
> Signed-off-by: Markus Elfring <Markus.Elfring@xxxxxx>
Yours sincerely,
Vincent Mailhol