Re: [PATCH 0/3] platform/x86: think-lmi: Fix resource cleanup flaws

From: Mark Pearson
Date: Sat Jun 28 2025 - 15:31:29 EST


Thanks Kurt,

On Sat, Jun 28, 2025, at 2:00 PM, Kurt Borja wrote:
> Hi all,
>
> First patch is a prerequisite in order to avoid NULL pointer
> dereferences in error paths. Then two fixes follow.
>
> Signed-off-by: Kurt Borja <kuurtb@xxxxxxxxx>
> ---
> Kurt Borja (3):
> platform/x86: think-lmi: Create ksets consecutively
> platform/x86: think-lmi: Fix kobject cleanup
> platform/x86: think-lmi: Fix sysfs group cleanup
>
> drivers/platform/x86/lenovo/think-lmi.c | 92 ++++++++++++---------------------
> 1 file changed, 33 insertions(+), 59 deletions(-)
> ---
> base-commit: 73f0f2b52c5ea67b3140b23f58d8079d158839c8
> change-id: 20250628-lmi-fix-98143b10d9fd
> --
> ~ Kurt

The patches all look good to me:
Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>

The only caveat is I tried a build and system won't boot. I don't think it's related to your changes, but it means I've not been able to actually test them to confirm all working normally. I'll dig a bit more and figure out what is going on.

Mark