Re: [PATCH] iio: dac: ad3530r: Fix incorrect masking for channels 4-7 in powerdown mode

[Jonathan Cameron]

On Fri, 27 Jun 2025 16:54:33 +0100
Nuno Sá <noname.nuno@xxxxxxxxx> wrote:

> On Thu, 2025-06-26 at 16:38 +0800, Kim Seer Paller wrote:
> > In the current implementation of ad3530r_set_dac_powerdown() function,
> > the macro AD3530R_OP_MODE_CHAN_MSK(chan->channel) is used to generate
> > the bitmask for the operating mode of a specific channel. However, this
> > macro does not account for channels 4-7, which map to the second
> > register AD3530R_OUTPUT_OPERATING_MODE_1 for the 8 channeled device. As
> > a result, the bitmask is incorrectly calculated for these channels,
> > leading to improper configuration of the powerdown mode. Resolve this
> > issue by adjusting the channel index for channels 4-7 by subtracting 4
> > before applying the macro. This ensures that the correct bitmask is
> > generated for the second register.
> > 
> > Fixes: 93583174a3df ("iio: dac: ad3530r: Add driver for AD3530R and AD3531R")
> > Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> > ---  
> 
> LGTM,
> 
> Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan