Re: [PATCH v13 1/7] mfd: Add core driver for Nuvoton NCT6694

From: Markus Elfring
Date: Sat Jun 28 2025 - 08:31:28 EST



> +++ b/drivers/mfd/nct6694.c
> @@ -0,0 +1,390 @@

> static void nct6694_irq_enable(struct irq_data *data)
> +{

> + spin_lock_irqsave(&nct6694->irq_lock, flags);
> + nct6694->irq_enable |= BIT(hwirq);
> + spin_unlock_irqrestore(&nct6694->irq_lock, flags);
> +}


Will development interests grow to apply a statement
like “guard(spinlock_irqsave)(&nct6694->irq_lock);”?
https://elixir.bootlin.com/linux/v6.16-rc3/source/include/linux/spinlock.h#L585-L588

Regards,
Markus