Re: [PATCH v2 0/3] replace `allow(...)` lints with `expect(...)`
From: Onur
Date: Sat Jun 28 2025 - 00:09:15 EST
On Fri, 27 Jun 2025 17:55:41 +0200
Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> On Fri, Jun 27, 2025 at 8:54 AM Onur Özkan <work@xxxxxxxxxxxxx> wrote:
> >
> > The `#[allow(clippy::non_send_fields_in_send_ty)]` removal was
> > tested on 1.81 and clippy was still happy with it. I couldn't test
> > it on 1.78 because when I go below 1.81 `menuconfig` no longer
> > shows the Rust option. And any manual changes I make to `.config`
> > are immediately reverted on `make` invocations.
>
> For that, I recommend using the `/` command inside `menuconfig` -- it
> allows you to see the dependencies of a given symbol, and whether they
> are met or not. That way, it allows one to understand what else may be
> missing to enable a symbol.
>
> I hope that helps.
>
> Cheers,
> Miguel
I already tried that but it didn't helped. I was able to make it work
with manually hacking the `init/Kconfig` file.
Removal of `#[allow(clippy::non_send_fields_in_send_ty)]` still works
as expected, but using `#![expect(internal_features)]` (which was done
in the first diff) doesn't work on 1.78. I will revert that and send v3
patch in a short.
Regards,
Onur